Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore IE Mode e2e testing in Windows #1089

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

Jaifroid
Copy link
Member

Fixes #1088. This test got accidentally removed in a recent PR. Please see explanation in #1088 as to why I don't believe it's worth running Chrome (as opposed to Edge) tests specifically in the Windows VM. Testing is already quite slow, so we should focus on tests that clearly add value.

@Jaifroid Jaifroid added regression Broken things that used to work tests build Code relating to building, publishing, or maintaining the app labels Aug 31, 2023
@Jaifroid Jaifroid added this to the v4.0 milestone Aug 31, 2023
@Jaifroid Jaifroid self-assigned this Aug 31, 2023
@Rishabhg71
Copy link
Collaborator

@Jaifroid, I like your idea of removing the Chrome Windows Tests, as all tests were taking around 8 minutes to complete. Continuing this discussion, I believe there's an opportunity to explore an even more effective solution. Currently, the tests are categorized by OS. Perhaps, we could consider a different categorization approach. Presently, Windows tests involve about 3 to 4 steps, whereas Linux tests encompass around 10 to 12 steps. Let's brainstorm for potential improvements.

@Jaifroid
Copy link
Member Author

Great, thank you! The main aim here was to reintroduce the IE11 test (IE Mode), and so as not to extend the Windows tests even more, it seemed best to remove the Chrome test which is really redundant on Windows if we are also testing in Edge. I agree we should look for ways of making tests more efficient if possible. They run significantly faster on Linux than on Windows (I suspect because the Windows VMs on GitHub just don't have so many runners), but we do need some Windows testing. I'll merge now.

@Jaifroid Jaifroid merged commit 33aaf8c into main Aug 31, 2023
9 checks passed
@Jaifroid Jaifroid deleted the Restore-IE-Mode-e2e-testing-in-Windows branch August 31, 2023 17:44
@Jaifroid Jaifroid modified the milestones: v4.0, v3.10 Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Code relating to building, publishing, or maintaining the app regression Broken things that used to work tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore testing in IE11 Mode in the Windows tests
2 participants