Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Manifest V3 for Firefox #1121

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Conversation

Jaifroid
Copy link
Member

This is for testing the MV3 extension in Firefox, as discussed in #1120.

To test, rename manifest.json to manifest.cr.v3.json, and then rename manifest.fx.v3.json to manifest.json. Then install a temporary Firefox extension in the usual way.

In sum: it works just like the old extension. It still requires using the remote PWA to run Service Workes as they are still completely disabled in Firefox MV3 extensions.

@Jaifroid Jaifroid added do-not-merge Sample code extensions Code relating to the production or running of browser extensions labels Sep 12, 2023
@Jaifroid Jaifroid self-assigned this Sep 12, 2023
@Jaifroid
Copy link
Member Author

Hmm, it looks like we'd need two versions of backgroundscript.js given the API change...
It would be better to wait until Mozilla supports Service Workers as background scripts....

@Jaifroid Jaifroid marked this pull request as ready for review September 13, 2023 09:24
@Jaifroid Jaifroid added build Code relating to building, publishing, or maintaining the app and removed do-not-merge Sample code labels Sep 13, 2023
@Jaifroid
Copy link
Member Author

This now builds useable MV2 and MV3 versions for Firefox.

@Jaifroid Jaifroid merged commit 9d3fe6e into main Sep 13, 2023
9 checks passed
@Jaifroid Jaifroid deleted the Switch-to-Manifest-V3-for-Firefox branch September 13, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Code relating to building, publishing, or maintaining the app extensions Code relating to the production or running of browser extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant