Update babel-core and fix vulnerabilities #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaifroid
added
dependencies
|
@Rishabhg71 FYI, it looks like the issue with the dependabot updates not passing tests is that dependabot doesn't have access to the site secrets, so can't run tests on BrowserStack. It seems like it has enough access to be considered an internal contributor, but not enough to run the BrowserStack tests, hence the failures. In any case, by updating babel-core and running npm install, and then npm audit fix, I got the same updates, and have pushed them to this PR, which is passing tests. So I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing if tests work when pushed by maintainer.