Fix some anomalies in tests #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With these changes, tests now appear to be stabilized. @Rishabhg71, if you're happy with the changes, please approve, or make suggestions if not. |
Jaifroid
commented
Nov 16, 2023
Jaifroid
commented
Nov 16, 2023
Jaifroid
commented
Nov 16, 2023
Jaifroid
commented
Nov 16, 2023
Rishabhg71
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables Edge testing on Linux in GitHub, because we already test on Windows extensively in Edge, and there is a Chrome test in Linux which is the same thing.
It also fixes some of the descriptions of tests, and restricts the Firefox 70 test on BrowserStack to SW mode as stated in the test title.