Add content warning for zimit2 in service worker local mode #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaifroid
added
user interface
accessibility
extensions
Jaifroid
deleted the
Add-content-warning-for-zimit2-in-ServiceWorkerLocal-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although mostly static archives work well in Chromium extensions in ServiceWorkerLocal mode, highly dynamic ZIMs that contain inline JS (a poor coding practice, but highly prevalent) will have non-functional elements. This is because inline JS is banned in Chromium extensions, even in MV3.
But we have a workaround, which is to reload the app as a PWA from browser-extension.kiwix.org. We should therefore warn users opening zimit2 archives.
This PR modifies the JQuery "active content warning", so that it also shows on zimit2 landing pages when a user is in ServiceWorkerLocal mode.