Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduced margin between search button and result text #1216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aditya0049
Copy link

solved this issue #1214
Remove unnecessary space below search bar when screen is narrow

@Jaifroid
Copy link
Member

@Aditya0049 Thanks for the PR. I'm just running automated tests, then I'll test it myself and get back to you.

@Jaifroid
Copy link
Member

@Aditya0049 It's looking good, but I think it needs two things:

  1. Make the space above the bar equal to the space below it (see screenshot below, where I drew squiggly yellow line);
  2. Reduce the size of the search bar and the search button when the screen is narrow (they should be at least the size of the Random button).

You'll see in the CSS some code that reduces the size of the bottom toolbar buttons. We need something similar for the search bar area. You can probably just copy (roughly) the CSS rules. You should ensure that Random button, Search button and search text field are the same height so they match.

I realize there are a few things here that weren't in the original issue, but seeing it after your changes makes the need for them more obvious!

image

@ehtishama
Copy link

Hi @Aditya0049, I noticed there hasn't been any activity in a while. Are you still working on this issue? If not, I'd like to take on this issue.

@Aditya0049
Copy link
Author

Hi @Aditya0049, I noticed there hasn't been any activity in a while. Are you still working on this issue? If not, I'd like to take on this issue.

I'm working ....it'll be done till next 2 days

@Jaifroid Jaifroid self-requested a review May 20, 2024 08:16
Copy link
Member

@Jaifroid Jaifroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See changes mentioned here: #1216 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants