Remove unused removeDuplicateTitlesInDirEntryArray() #491 #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaifroid
approved these changes
Jul 22, 2019
There was a problem hiding this comment.
I've tested this quickly in Edge 44, and it doesn't seem to break anything. I see your editor has done some whitespace cleanup, which is fine. We should wait for @mossroy to take a look, to see if the Unit Test might have had any reason for being there.
mossroy
approved these changes
Jul 22, 2019
|
@kelson42 Are you happy to merge this? |
|
@Jaifroid I have no clue what this PR is about. Don't really understand why you ask me. |
|
Ah, I thought it was your PR! You asked us to review, and I think we've both approved. But I'll merge it now. |
|
@Jaifroid You are right, sorry, I'm ready for the bed ;) Thx for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #491