-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize the libzim worker #934
Conversation
Seems to initialize properly:
|
Codefactor warning is on the library file. I've set it to ignore. |
When loading a split ZIM with a full text index, we get:
Clearly an exception is being thrown. It doesn't prevent the archive from loading and displaying, but if we can't fix this now, we should work around it by adding split ZIM detection. |
This is an error quite deep in the virtual file system code. I don't think it is in the scope of this PR. I'll add an issue for it on javascript-libzim, and we need to prevent libzim loading if we have a split archive here for now. |
Fixes #929.
Currently there is no code to prevent initialization if the archive is split arbitrarily. I would prefer to be able to test what happens in this scenario.