Remove unused functions from util.js(#843) #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaifroid
approved these changes
Dec 11, 2022
There was a problem hiding this comment.
@amitpanwar789 Many thanks for this PR. It all looks good to me!
Are you ready for me to squash/merge? It will appear as your commit/contribution.
|
@Jaifroid all good from my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #843
Removed the following functions from util.js
readIntegerFrom4Bytes
readIntegerFrom2Bytes
uint8ArrayToHex
I have done basic UI tests maintained in contributing.md and all were passed successfully.
@Jaifroid can you please review it.