Initiate full-text search earlier #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cf1071a.
|
I tested reporting each dirEntry promise as soon as it resolves, but it doesn't make enough of a difference and complicates the code. It might be possible to use the Search API to pull fewer results at a time in a more progressive way, but that would be for another PR, perhaps one that includes optional Suggestions. |
Jaifroid
deleted the
Initiate-full-text-search-in-parallel-with-title-search
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #940.
It would be worth seeing if we can report interim results while waiting for dirEntry lookup promises to resolve.