Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile zstdec and xzdec as es6 modules #998

Merged
merged 9 commits into from
May 4, 2023
Merged

Compile zstdec and xzdec as es6 modules #998

merged 9 commits into from
May 4, 2023

Conversation

Jaifroid
Copy link
Member

@Jaifroid Jaifroid commented Apr 30, 2023 •
edited

In order to experiment with ES6 module loading for #554, it is necessary to compile zstdec and xzdec explicitly as ES6 modules, using the option -s EXPORT_ES6=1.

@Jaifroid Jaifroid added do-not-merge Sample code dependencies Pull requests that update a dependency file build Code relating to building, publishing, or maintaining the app labels Apr 30, 2023
@Jaifroid Jaifroid self-assigned this Apr 30, 2023
@Jaifroid Jaifroid changed the title Compile zstdec and xzdec as es6 modules Compile update versions of zstdec and xzdec May 4, 2023
@Jaifroid Jaifroid changed the title Compile update versions of zstdec and xzdec Compile zstdec and xzdec as es6 modules May 4, 2023
@Jaifroid Jaifroid marked this pull request as ready for review May 4, 2023 21:48
@Jaifroid Jaifroid merged commit 2b4ff6b into main May 4, 2023
9 checks passed
@Jaifroid Jaifroid deleted the Compile-zstdec-and-xzdec-as-es6-modules branch May 4, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jaifroid Jaifroid

Labels
build Code relating to building, publishing, or maintaining the app dependencies Pull requests that update a dependency file do-not-merge Sample code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Jaifroid