Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian: Have libkiwix-dev depend on libmicrohttpd-dev #419

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Oct 29, 2020

As of 9c925f6, it's now required in the pkg-config file.

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #419 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #419   +/-   ##
=======================================
  Coverage   58.29%   58.29%           
=======================================
  Files          50       50           
  Lines        3623     3623           
  Branches     1810     1810           
=======================================
  Hits         2112     2112           
  Misses       1508     1508           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e2d174...41cee1c. Read the comment docs.

@kelson42
Copy link
Collaborator

Looks good but surprisingly the compilation does not pass on macOS, adding @mgautierfr to the reviewers.

@kelson42
Copy link
Collaborator

This PR seems to fail because of the subprojects directory. If we remove it it works fine.

As of 9c925f6, it's now required in the pkg-config file.
@kelson42
Copy link
Collaborator

kelson42 commented Nov 4, 2020

Rebased

@kelson42 kelson42 merged commit 038e86e into master Nov 4, 2020
@kelson42 kelson42 deleted the legoktm-patch-1 branch November 4, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants