Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startup message to provide http url to server #499

Merged
merged 1 commit into from Dec 22, 2021
Merged

Conversation

juuz0
Copy link
Collaborator

@juuz0 juuz0 commented Nov 29, 2021

Fixes #473
Needs kiwix/libkiwix#622.

@juuz0 juuz0 requested a review from kelson42 November 29, 2021 12:01
@kelson42 kelson42 marked this pull request as ready for review November 29, 2021 14:14
@kelson42
Copy link
Contributor

@juuz0 Thx, will give a check.

@juuz0
Copy link
Collaborator Author

juuz0 commented Dec 1, 2021

@kelson42 I'm changing a few things in this and kiwix/libkiwix#622 in sometime
Please let me know if they are better :)

@juuz0
Copy link
Collaborator Author

juuz0 commented Dec 1, 2021

@kelson42 Done 👍

Copy link
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me

@kelson42 kelson42 merged commit 9b15836 into master Dec 22, 2021
@kelson42 kelson42 deleted the startup-message branch December 22, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kiwix-serve does not display a startup message after invocation
2 participants