Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip connection limit option #534

Merged
merged 2 commits into from Feb 6, 2022
Merged

Add ip connection limit option #534

merged 2 commits into from Feb 6, 2022

Conversation

juuz0
Copy link
Collaborator

@juuz0 juuz0 commented Feb 5, 2022

Fixes #106
Part 2: kiwix/libkiwix#700

Adds --ipConnectionLimit/-L option to change MHD_OPTION_PER_IP_CONNECTION_LIMIT by calling server.setIpConnectionLimit()
Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically an approval. But let's first merge kiwix/libkiwix#700 (upon which this PR depends) and rerun the CI the next day (the only almost-non-issue that I noticed can be used to that end).

src/server/kiwix-serve.cpp Outdated Show resolved Hide resolved
@kelson42 kelson42 merged commit dd5aa33 into master Feb 6, 2022
@kelson42 kelson42 deleted the ipLimit branch February 6, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid one IP to take all the connections of the pool
3 participants