Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default kiwix-serve's rootLocation to "/" #571

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Default kiwix-serve's rootLocation to "/" #571

merged 2 commits into from
Jul 28, 2022

Commits on Jul 28, 2022

  1. Default kiwix-serve's rootLocation to "/"" 

    Usage mentions that the rootLocation defaults to `/` while it was not.
It defaulted to an empty string.

While it defaulting to "" or "/" has no technical consequence: libkiwix's server
normalizes the requested rootLocation ; it leads to users setting a "/"-prefixed
rootLocation when customizing it, resulting in double-slashed print of the URL
to access kiwix-serve at.

This harmonizes usage and actual default, fixing the URL print.
    @rgaudin
    rgaudin committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    9c16e53 View commit details
    Browse the repository at this point in the history

  2. Normalize printed rootLocation 

    Reusing libkiwix's normalizeRootUrl() to display a more reliable representation of the
rootLocation the InternalServer will be using.

Can't reuse server.m_root as it is private.
    @rgaudin
    rgaudin committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    442de30 View commit details
    Browse the repository at this point in the history