Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images for new architectures #622

Merged
merged 1 commit into from Jun 16, 2023
Merged

Docker images for new architectures #622

merged 1 commit into from Jun 16, 2023

Conversation

rgaudin
Copy link
Member

@rgaudin rgaudin commented May 24, 2023

  • Fixes the release filename for arm64 and armv7
  • Add new architectures for i386 and armv6

Attention ⚠️: this currently points to non-existing files as the filenames have changed in nightly but we haven't released since the change. Can be merged but should not be run until next release.

@rgaudin rgaudin self-assigned this May 24, 2023
@kelson42
Copy link
Contributor

@rgaudin Not forgotting that current kiwix-tools for ARM linux are broken

@rgaudin
Copy link
Member Author

rgaudin commented May 24, 2023

@rgaudin Not forgotting that current kiwix-tools for ARM linux are broken

AFAIK the nightlies are fixed and that led to new names (hence this PR) so it's not an additional concern

Copy link
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Fixes the release filename for arm64 and armv7
- Add new architectures for i386 and armv6
@kelson42 kelson42 merged commit 92ee72a into main Jun 16, 2023
12 checks passed
@kelson42 kelson42 deleted the new-archs branch June 16, 2023 16:03
@kelson42 kelson42 modified the milestones: 3.5.0, 3.6.0 Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants