Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nofilter attribute and iframe conditions #587

Closed
wants to merge 1 commit into from

Conversation

MananJethwani
Copy link
Contributor

this resolves #585

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #587 (f4ba474) into master (03a929e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   64.92%   64.92%           
=======================================
  Files          53       53           
  Lines        3738     3738           
  Branches     1881     1881           
=======================================
  Hits         2427     2427           
  Misses       1309     1309           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a929e...f4ba474. Read the comment docs.

@MananJethwani
Copy link
Contributor Author

To include a widget on the MediaWiki server we will require https://www.mediawiki.org/wiki/Extension:Iframe, and to make it a bit responsive we need to use width:100% for some reason vh and vw don't work for the MediaWiki based servers.

@stale
Copy link

stale bot commented Jul 30, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jul 30, 2021
@mgautierfr
Copy link
Member

@MananJethwani Is this PR a draft or ready to be reviewed ?

@stale stale bot removed the stale label Aug 3, 2021
@MananJethwani
Copy link
Contributor Author

@mgautierfr it's still a draft, @kelson42 asked me too test it on a wiki but for some reason I am not able to use widget extension for mediawiki as of now....will have a look in some time after solving some other tickets.

@stale
Copy link

stale bot commented Aug 18, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Aug 18, 2021
@kelson42
Copy link
Collaborator

@juuz0 Please consider this PR. We will have to decide if hidding completly the top searchbar should be done like this via a parameter, or this can be done easily, just by customising the CSS of iframe HTML (to me sounds preferable).

@stale stale bot removed the stale label Jun 25, 2022
@kelson42 kelson42 closed this Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kiwix-serve should propose widgets
3 participants