Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undefined check for humanFriendlyTitle #687

Merged
merged 1 commit into from
Jan 23, 2022
Merged

Conversation

juuz0
Copy link
Collaborator

@juuz0 juuz0 commented Jan 21, 2022

Fixes #685

@juuz0 juuz0 requested a review from kelson42 January 21, 2022 17:27
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #687 (df2654f) into master (234606b) will not change coverage.
The diff coverage is n/a.

❗ Current head df2654f differs from pull request most recent head 270773d. Consider uploading reports for the commit 270773d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #687   +/-   ##
=======================================
  Coverage   60.80%   60.80%           
=======================================
  Files          54       54           
  Lines        3944     3944           
  Branches     1994     1994           
=======================================
  Hits         2398     2398           
  Misses       1545     1545           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 234606b...270773d. Read the comment docs.

Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If title is undefined, the the line 56 is useless or might even fail IMO. I believe we should test first then do the stuff… return empty string otherwise.

humanFriendlyTitle() now returns an empty string if title is undefined
which is handled in loadAndDisplayOptions()
@kelson42 kelson42 merged commit ceb46f1 into master Jan 23, 2022
@kelson42 kelson42 deleted the langCatBoxFill branch January 23, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http://library.kiwix.org does not achieve to populate its cateogry select box
2 participants