Add span in querySelector #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier querySelector for download button was returning a div, on which we called the getAttribute function hence returning null This now returns a <span> element which returns the correct link with getAttribute
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
=======================================
Coverage 60.80% 60.80%
=======================================
Files 54 54
Lines 3944 3944
Branches 2006 2006
=======================================
Hits 2398 2398
Misses 1545 1545
Partials 1 1 Continue to review full report at Codecov.
|
kelson42
approved these changes
Jan 24, 2022
|
@juuz0 Thx, fixes the problem for me. Will deploy tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #690