Render xml result - opensearch #731
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
|
@mgautierfr This PR has not been updated since a month and is a blocker to the - pretty urgent to be released - milestone 10.2.0. As far as I understand it depends on #729 to fully work. But it would be great to finish/polish it ASAP (whatever if #729 is merged or not) so @veloman-yunkan can start to review it (and that way we can parallellize the work and speed-up). |
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 63.48% 63.60% +0.11%
==========================================
Files 59 59
Lines 4050 4077 +27
Branches 2204 2220 +16
==========================================
+ Hits 2571 2593 +22
- Misses 1477 1481 +4
- Partials 2 3 +1
Continue to review full report at Codecov.
|
|
@veloman-yunkan While this PR is based on #729 it would like a small review :) |
mgautierfr
force-pushed
the
multizimsearch
branch
2 times, most recently
from
96ea2c8
to
8893f84
Compare
kelson42
changed the title
|
@veloman-yunkan Any new feedback on this PR? |
|
@kelson42 I will review it by Monday morning. |
mgautierfr
force-pushed
the
multizimsearch
branch
4 times, most recently
from
813e6fb
to
1b3da9f
Compare
mgautierfr
force-pushed
the
multizimsearch
branch
2 times, most recently
from
13c8318
to
995d15f
Compare
mgautierfr
force-pushed
the
multizimsearch
branch
2 times, most recently
from
684e5dc
to
a7651d0
Compare
mgautierfr
force-pushed
the
opensearch
branch
2 times, most recently
from
624a74d
to
3d911ce
Compare
| const std::vector<std::string> LARGE_SEARCH_RESULTS = { | ||
| SEARCH_RESULT( | ||
| /*link*/ "/ROOT/zimfile/A/Genius_+_Soul_=_Jazz", | ||
| /*title*/ "Genius + Soul = Jazz", | ||
| /*snippet*/ R"SNIPPET(...Grammy Hall of Fame in 2011. It was re-issued in the UK, first in 1989 on the Castle Communications "Essential Records" label, and by Rhino Records in 1997 on a single CD together with Charles' 1970 My Kind of <b>Jazz</b>. In 2010, Concord Records released a deluxe edition comprising digitally remastered versions of Genius + Soul = <b>Jazz</b>, My Kind of <b>Jazz</b>, <b>Jazz</b> Number II, and My Kind of <b>Jazz</b> Part 3. Professional ratings Review scores Source Rating Allmusic link Warr.org link Encyclopedia of Popular Music...)SNIPPET", | ||
| /*bookTitle*/ "Ray Charles", | ||
| /*wordCount*/ "242" | ||
| ), | ||
|
|
There was a problem hiding this comment.
We better avoid this huge duplication between server_xml_search.cpp and server_html_search.cpp test suites
There was a problem hiding this comment.
I totally agree with you. But I think it is better for now to merge the PR as it is now to avoid too long review process (as long as the code is working).
But we need to do that in next future.
mgautierfr
force-pushed
the
opensearch
branch
2 times, most recently
from
c64cce7
to
1708074
Compare
The file starts now to be too long. - Move testing of the search html result in `test/server_html_search.cpp` - Move common code used to launch server and so in `test/server_testing_tools.h' This is mainly code move with a small change: Instead of setting the default PORT (8001) as a const int in the `ServerTest` class, we now use SERVER_PORT. SERVER_PORT must be defined before include `server_testing_tools.h`. This allow several test to be run in parallele without trying to open the same port.
It avoid some duplication around the actual data to test.
`test/server_xml_search.cpp` is a plain copy of `test/server_html_search.cpp`
This is the real change.
|
CodeFactor's failure is due to a bug in CodeFactor - nothing of the kind reported by CodeFactor is in the code. |
Fixes #586