Safe href in suggestion links for the iframe-based viewer #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 71.04% // Head: 71.04% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #859 +/- ##
=======================================
Coverage 71.04% 71.04%
=======================================
Files 53 53
Lines 3685 3685
Branches 2058 2058
=======================================
Hits 2618 2618
Misses 1065 1065
Partials 2 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mgautierfr
approved these changes
Dec 14, 2022
This was referenced Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses kiwix/kiwix-tools#587 with respect to suggestions in the iframe-based viewer.
The value of the
hrefattributed is assumed to always be a URI-encoded string that has to be decoded. This is true for URLs withjavascript:scheme too.The following example demonstrates the problem
Invoking inline javascript via the first link displays URL-decoded text ("A&B"). Running out-of-line javascript via the second link display the text as is ("A%26B").
This means that suggestion links in the iframe-based viewer that work via javascript need a second level of URL-encoding.