Fix git clone on Windows

[adamlamar]

This changes wtf? to wtf#. The ? is not allowed in filenames or directories on Windows, but # is. If I understand #775 correctly, the # should be a reasonably good substitute since it has the same requirements as ?.

The corner case zimfile was also updated accordingly and the test should pass.

Successful clone on Windows:

$ git clone https://github.com/adamlamar/libkiwix.git
Cloning into 'libkiwix'...
remote: Enumerating objects: 12725, done.
remote: Counting objects: 100% (210/210), done.
remote: Compressing objects: 100% (97/97), done.
remote: Total 12725 (delta 127), reused 168 (delta 111), pack-reused 12515
Receiving objects: 100% (12725/12725), 6.99 MiB | 11.50 MiB/s, done.
Resolving deltas: 100% (8415/8415), done.

Fixes #867

[veloman-yunkan]

@adamlamar Thank you for the fix!

I have only one very superficial objection. Question mark plays well with wtf (and that is why some mental effort was spent on picking up a good and short question-like meme when creating a new unit test for #866). Anyone looking at the new filenames may experience some cognitive dissonance. They might think:

- WTF? Why "wtf#"? Shouldn't it be "wtf?"? 😄

They will definitely have hard time figuring out the reason behind this counterintuitive usage of the hash symbol.

There are two solutions:

1. Replace the entire "wtf?" string with another one containing a hash symbol (e.g. C#). For consistency I would also update the content of the HTML file.
2. Assuming that the create_corner_cases_zim_file is not supposed to be executed on Windows, the "wtf?" files can be generated from inside that script.

And, BTW, nothing prevents us from implementing both options - then both "#" and "?" will be tested!

@mgautierfr What do you think? Should we just merge this PR or it makes sense to pursue consistency that perhaps no one will care about?

[adamlamar]

Hey @veloman-yunkan, I agree it would be better if the test case made more sense in semantic terms. wtf# is a bit weird :) I was just laser focused on fixing this one issue since its blocking the kiwix-desktop windows build. I like the C# suggestion, pushed a change using C#.

[adamlamar]

Oh and I agree that we could write a test case for all of the characters that need encoding (?, #, & if I understand correctly), but we'd have to avoid committing the file with ?. I suppose we could have the script generate the necessary files, create the zim file, and then delete them (without committing to git).

[veloman-yunkan]

This comment applies to the name of the file.

Holding on to my previous concern wrt semantic consistency, I have to note that C is not C#. Maybe rename this file to c_sharp.html?

[adamlamar]

Should be fixed now 👍

[veloman-yunkan]

Almost good to merge.

However, I don't think that we need all those three commits (each with their own 36KiB version of corner_cases.zim) in the history. Please squash all commits into one with a commit message explaining why the change is more extensive than it could have been.

[adamlamar]

Sure, I squashed and pushed.

[veloman-yunkan]

Thanks for bearing with me and my whims!