A pseudosafe iframe #906
Merged
A pseudosafe iframe #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents scripts running inside an iframe from inadvertently manipulating the top browsing context. However a malicious script could still remove the sandboxing imposed on it (because the combination of "allow-same-origin" and "allow-scripts" is vulnerable).
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
=======================================
Coverage 72.00% 72.00%
=======================================
Files 54 54
Lines 3751 3751
Branches 2096 2096
=======================================
Hits 2701 2701
Misses 1048 1048
Partials 2 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mgautierfr
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fixes" kiwix/kiwix-tools#604.
This prevents scripts running inside an iframe from inadvertently manipulating the top browsing context. However a malicious script could still remove the sandboxing imposed on it (because the combination of "allow-same-origin" and "allow-scripts" is vulnerable).