Fix build error C2036 on Windows #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Just pinging. We'd like to update the version of |
t20100
commented
Oct 20, 2022
| nbytes = ZSTD_decompress(tmp_buf, size * elem_size, in + 4, nbytes_from_header); | ||
| nbytes = ZSTD_decompress(tmp_buf, size * elem_size, (void *)((char *) in + 4), nbytes_from_header); |
There was a problem hiding this comment.
Fixed with similar casting as used in other places, e.g.:
Line 66 in fdfcd40
t20100
added a commit
to t20100/hdf5plugin
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get the following error when build on Windows with Microsoft Visual Studio 14.0:
bitshuffle.c(185): error C2036: 'const void *': unknown sizeThis PR fixes it.