Windows MSVC #68
Windows MSVC #68
Conversation
setup.py
Outdated
| e.extra_link_args += ['-fopenmp'] | ||
| if openmpflag not in e.extra_compile_args: | ||
| e.extra_compile_args += [openmpflag] | ||
| e.extra_compile_args += compileflags |
There was a problem hiding this comment.
compileflags only gets added to e.extra_compile_args if compiling with openmp. Maybe move to the _needs_stub loop, but be careful that they only get added once (I seem to remember build_extensions being called multiple times being an issue.
src/bitshuffle_core.c
Outdated
| @@ -1138,7 +1138,7 @@ int64_t bshuf_untrans_bit_elem(const void* in, void* out, const size_t size, | |||
| int64_t bshuf_blocked_wrap_fun(bshufBlockFunDef fun, const void* in, void* out, \ | |||
| const size_t size, const size_t elem_size, size_t block_size) { | |||
|
|
|||
| size_t ii; | |||
| long long ii; | |||
There was a problem hiding this comment.
MSVC openmp doesn't like the size_t type
There was a problem hiding this comment.
But it is used throughout the code and is a very standard type. Why only this one place?
There was a problem hiding this comment.
The openmp pragma (as iterator)
There was a problem hiding this comment.
Okay fair enough. Maybe state this in a comment above this line so it doesn't bewilder future developers.
setup.py
Outdated
| @@ -19,7 +19,7 @@ | |||
| VERSION_POINT = 4 | |||
|
|
|||
| # Only unset in the 'release' branch and in tags. | |||
| VERSION_DEV = 1 | |||
There was a problem hiding this comment.
Only allowed in the release branch. Please change back.
Patche set for compiling the plugin on Windows