-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issue #181
Comments
You are right. I have been considering a |
It would really help. Moreover, I want to suggest to you, check generating months dynamically after user's swipe. It could also become a part of infinite calendar. But it seems that it need to rewrite lot of logic, so mb think about it for far future |
First of all, thank you @kizitonwose for such a wonderful library. I appreciate the time that you spent on making so many things customizable. Unfortunately, I must say that the performance is a dealbraker for me. I have a BottomNavigationView in my app, and when I switch to the CalendarView, it takes a whole lot for the tab to be displayed. I did not dive into the code so I don't know what is the problem here, but I may assume that you're generating all the months and days that are not visible (I concluded this because the scrolling is super smooth). Is there a way for me to configure this? The scrolling isn't important for me. Lazy loading is definitely what you should do here. |
Yep, this is on my TODO, just need to find the time. |
Not at the moment but the async setup should come this weekend(hopefully), and that should be sufficient until lazy loading is possible. |
Would be really great to get this feature |
Happy to announce that |
Hi there.
Great lib, but it has really big problems with optimizations on long-range setup (e.g. -100 years, +100 years) because of
generateWeekDays
. It calls for each month and loads main thread. On a weak device it could take up to 5-10 seconds, which looks not very good. Seems like you need to review this approach.You can find it in Example3 if you set up it like this:
The text was updated successfully, but these errors were encountered: