Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method not updating Setpoint #566

Closed
mrplow opened this issue Nov 17, 2018 · 8 comments
Closed

Method not updating Setpoint #566

mrplow opened this issue Nov 17, 2018 · 8 comments

Comments

@mrplow
Copy link

mrplow commented Nov 17, 2018

Mycodo Issue Report:

  • Specific Mycodo Version: 6.4.5

Problem Description

  • My room heater function does work. I created a method to drop the temperature to 14C during the day and 18C during the night, however, the setpoint never changes on it's own and I have to manually change it.

Errors

  • no messages or errors in daemon log.

Additional Notes

Since 7.0.0 is being worked on and, I assume, that a lot of this code is going to be rewritten this isn't a high priority issue. I'm hoping this is a misconfiguration issue.

pid
method

@kizniche
Copy link
Owner

It does look like an issue with Mycodo and not a misconfiguration. I'll try to replicate it on the 7.0 branch.

kizniche added a commit that referenced this issue Nov 19, 2018
@mrplow
Copy link
Author

mrplow commented Nov 19, 2018

Thanks @kizniche
I manually merged these changes into my 6.4.5 install and my method is now working properly

@drgrumpy
Copy link

@mrplow please can you tell me precisely what you merged, I have a similar issue with 6.4.5, and I don't want to risk upgrading....

I have a lighting PID and a daily method to set the setpoint from 06:00 to 18:00, but it seems that it is being ignored.

@mrplow
Copy link
Author

mrplow commented Feb 13, 2019

@drgrumpy see the changelog here 6d361e0
Make backups of the files first 😎

@drgrumpy
Copy link

Thanks @mrplow. I suppose what I was really interested to know was did you just update the single line in controller_pid.py ? Or overwrite the whole file ?

The other stuff in that changelog is all about web display I think.

@mrplow
Copy link
Author

mrplow commented Feb 15, 2019

I just manually merged ALL the changes from that commit (except the readme.)
Good luck

@kizniche
Copy link
Owner

It looks like that one indentation change of controller_pid.py was all that was needed to fix this issue. The rest of the edits were for button styles.

@drgrumpy
Copy link

Thanks. That's what I thought. I just changed the indent on that one line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants