Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to remove dependency on yahoo #43

Closed
sbheinric opened this issue Nov 20, 2013 · 2 comments
Closed

Request to remove dependency on yahoo #43

sbheinric opened this issue Nov 20, 2013 · 2 comments

Comments

@sbheinric
Copy link

Because some crypto functions take a long time to run, I wanted to put them into a worker thread using HTML5 Web Workers.

However, the "yahoo-min.js" script which is packaged into "jsrsasign-latest-all.js" contains unnecessary references to the "window" object (open window in a browser)...which does not exist in the Web Worker context, and prevents it from being able to run there.

It would be nice to remove this dependency on yahoo anyway as it is unclear why it should be there

@GregTurner
Copy link

I second request for another reason.

On heavily data loaded angularjs/rx.js apps, the yahoo-min.js was eating 2.7secs of time. It seems to consume cycles for functions it shouldn't be involved in. After removing the dependency on jsrasign by removing it from an upstream lib we saw significant performance improvement (25%).

@kjur
Copy link
Owner

kjur commented Jun 24, 2017

Most of YUI codes are removed in 7.2.2 released today. It's just only YAHOO.lang.extend which is not vulnerable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants