Change rails? method to check railtie instead rails module
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y we avoid problems with actionmailer gem in non rails project
|
@antoniofilho why not use |
|
Also |
kjvarga
added a commit
that referenced
this pull request
Feb 13, 2017
…using action_mailer without Rails the rails-sanitizer-html gem defines a Rails module
|
Released in v5.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some non rails project depends on actionmailer, the rails-sanitizer-html gem is loaded and the Rails module is created, this way to check Rails module is not a good idea...
Take a look this issue rails/rails-html-sanitizer#25
A way to solve this is to check for specific methods instead Rails module or Railtie...