Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow AwsSdkAdapter to receive any Aws::S3::Client options #351

Merged
merged 8 commits into from
Jan 17, 2022

Conversation

nicolas-brousse
Copy link

This PR make SitemapGenerator::AwsSdkAdapter support any options of Aws::S3::Client.

That way SitemapGenerator::AwsSdkAdapter supports Minio backend, since it allow to use force_path_style option.

SitemapGenerator::AwsSdkAdapter.new(ENV["FOG_SITEMAP_BUCKET_NAME"],
  aws_access_key_id: ENV["FOG_SITEMAP_ACCESS_KEY_ID"],
  aws_secret_access_key: ENV["FOG_SITEMAP_SECRET_ACCESS_KEY"],
  aws_region: "us-east-1",
  aws_endpoint: ENV["FOG_SITEMAP_ENDPOINT"],
  force_path_style: true
)

What kind of changes may I add? I'm not sure if I need to update existing tests.
Maybe we may add a sentence about it in README.

Let me know 馃檪

@mcritchlow
Copy link

mcritchlow commented Jan 29, 2021

It would be really helpful to get a version of this in, as-is there's no easy way to get this working with Minio.

@Intrepidd
Copy link

Had the same issue, I use minio locally so I juste exported MINIO_DOMAIN=localhost to enable subdomain style for minio

@Intrepidd
Copy link

I actually had to use nip.io to be able to have local subdomains without installing dnsmasq or ruining my hosts file

MINIO_DOMAIN=127.0.0.1.nip.io

Then use http://127.0.0.1.nip.io:9000 as the endpoint

@kjvarga kjvarga merged commit 4e7f817 into kjvarga:master Jan 17, 2022
@kjvarga kjvarga added this to the v6.2.0 milestone Jan 17, 2022
@kjvarga
Copy link
Owner

kjvarga commented Jan 17, 2022

Released in 6.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants