Skip to content

Commit

Permalink
Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (kubeflow#2576)
Browse files Browse the repository at this point in the history
* Multiple issues tackled:
- Fixed webpack for windows (components/ is not a valid path in windows)
- Spacing and semicolons matched to old-codebase
- Added cross-platform support to npm run targets
- Added missing dep (babel/polyfill)
- Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions
- Pug fixed to match syntax for empty-value attributes
- Updated webpack for readability

* Added babel-polyfill to runtime deps rather than dev deps

* [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build

* Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035

* Fixed Multiple changes:
- Server port fixed to 8082 which is what is needed for GKE deployment
- Refactored some code

* Final working state for new image

* TS Changes

* Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f

* Migrated dev dependency to correct location

* Uncommented linter, fixed PR comments from @prodonjs
  • Loading branch information
Kam D Kasravi committed Mar 4, 2019
1 parent d4fa623 commit 7576876
Show file tree
Hide file tree
Showing 12 changed files with 67 additions and 456 deletions.
2 changes: 1 addition & 1 deletion components/centraldashboard/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ COPY webpack.config.js *.json ./

RUN npm install && npm run build && npm prune --production

EXPOSE 8080
EXPOSE 8082

ENTRYPOINT ["npm", "start"]
356 changes: 0 additions & 356 deletions components/centraldashboard/Gopkg.lock

This file was deleted.

0 comments on commit 7576876

Please sign in to comment.