Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Alt for Meta on Windows #122

Closed
akhilpai opened this issue Jul 20, 2017 · 3 comments
Closed

Broken Alt for Meta on Windows #122

akhilpai opened this issue Jul 20, 2017 · 3 comments
Labels

Comments

@akhilpai
Copy link

For both cmd.exe and powershell, the alt key has no effect as Meta in release 1.0.0. There are no problems with the control key, and the escape key may still be used as meta (although it cannot be held down and must be tapped before each command).

Occurs against toolchains:

stable-x86_64-pc-windows-msvc - rustc 1.19.0 (0ade33941 2017-07-17)
nightly-x86_64-pc-windows-msvc - rustc 1.20.0-nightly (582af6e1a 2017-07-19)

@gwenn
Copy link
Collaborator

gwenn commented Jul 21, 2017

I think it is fixed by a pending PR:

-            let alt = key_event.dwControlKeyState & (LEFT_ALT_PRESSED | RIGHT_ALT_PRESSED) ==
-                      (LEFT_ALT_PRESSED | RIGHT_ALT_PRESSED);
+            let alt = key_event.dwControlKeyState & (LEFT_ALT_PRESSED | RIGHT_ALT_PRESSED) != 0;

@akhilpai
Copy link
Author

Yes! It is fixed with your PR on my machine.

@gwenn gwenn added the bug label Aug 11, 2018
@gwenn
Copy link
Collaborator

gwenn commented Aug 26, 2018

2.0 released

@gwenn gwenn closed this as completed Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants