Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes/consistency improvements for multiline stuff #334

Merged
merged 4 commits into from Mar 7, 2020

Conversation

thomcc
Copy link
Contributor

@thomcc thomcc commented Feb 12, 2020

  • Movement::{BeginningOfLine,EndOfLine,etc} now actually go to beginning/end of the line.
  • Movement::BeginningOfBuffer, etc was added to get the original functionality back.
  • Fix some off-by-one bugs in the line movement code.
  • Make it easier to test the multiline functionality by adding a matching bracket validator, and using it in the examples.

@gwenn
Copy link
Collaborator

gwenn commented Feb 14, 2020

zsh seems to escape only '\n':

echo "\test\
t"
echo "\test\\
t"

@gwenn
Copy link
Collaborator

gwenn commented Feb 27, 2020

But zsh is buggy if line ends with a backslash:

$ echo test\\
$ # a space is appended in history 

@thomcc
Copy link
Contributor Author

thomcc commented Feb 27, 2020

That part is just so that if you have a multiline history item, after saving/loading it doesn't come back as individual lines.

Edit: Ah, nevermind, I misunderstood your point. I can rebase this this weekend.

@tailhook tailhook mentioned this pull request Feb 28, 2020
76 tasks
@gwenn
Copy link
Collaborator

gwenn commented Feb 29, 2020

With bash, Ctrl-A/Ctrl-E|Ctrl-U/Ctrl-K moves|kills to begin/end of buffer even with multiline input.
Maybe we should keep the current behaviour ?

@thomcc
Copy link
Contributor Author

thomcc commented Feb 29, 2020

It's a mix with what does what -- fish-shell and... every text editor supporting these have it go to the beginning of the line.

Also, as an anecdote: I use these very commonly and find going to the beginning of the buffer very frustrating (as it behaves differently than text editors).

@gwenn
Copy link
Collaborator

gwenn commented Feb 29, 2020

Ok.

@tailhook
Copy link
Contributor

tailhook commented Mar 5, 2020

Anything left for this PR to get merged (except resolving conflicts of course)? We already use the code from the branch, and are pretty happy with it.

@thomcc
Copy link
Contributor Author

thomcc commented Mar 5, 2020

Sorry, I was mistaken that I'd have time last weekend, but I have nothing else planned for this weekend/tomorrow afternoon and will rebase it.

@thomcc
Copy link
Contributor Author

thomcc commented Mar 7, 2020

This should be good now.

@gwenn gwenn merged commit afd7efb into kkawakam:master Mar 7, 2020
@gwenn
Copy link
Collaborator

gwenn commented Mar 7, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants