wip Config loading 2: revenge of runtime config #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
force-pushed
the
refactor-config-loading-2
branch
4 times, most recently
from
1d56dda
to
b178581
Compare
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
force-pushed
the
refactor-config-loading-2
branch
from
f2f0335
to
b033597
Compare
|
The PR is marked as stale since no activity has been recorded in 30 days |
|
The PR is marked as stale since no activity has been recorded in 30 days |
|
The PR is marked as stale since no activity has been recorded in 30 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keep the runtime config for now, but make it more obvious. also, make it hold k0svars and pid.
The commands like
token createand so on do also need k0svars, they're somewhat dependant on either a) the user at least supplying the same--data-diras the controller, which may not be enough or b) the defaults to be correct. They have no clue about--singleor--enable-dynamic-configfor example.The k0svars are now taken from the runtime config when runtime config is loaded, which is done when a command that does not have
--configof its own requires a k0s config yaml.