Cleanup my mess #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes an animation class causing a visual bug in IE. * Rush change log.
…on (microsoft#4835) * Fix selectors in TeachingBubble.scss. Add Primary and Secondary button to Coachmark basic example * Add onDismiss to example * Remove unused import * Add change file * Fix missing semis
* added support for remembering last focused item in a FTZ and restoring it when the FTZ gets focus. * rush change * removed onKeyDown from formal api; already present in nativeProps * use defaultProps for focusTransferRule * Correct type compile error on keybaord handler params * change new prop from enum to bool on CR suggestion * updated rush change msg * added isDefaultPrevented to FocusCapture handler * update change comment * update comment * Update ftz-rememberlastfocused_2018-05-16-22-37.json
microsoft#5108) * fixing official example page and datepicker/calendar components using box-sizing: content-box on the calendar component to prevent scroll bars * adding change file
* adding additional props to demopage * First batch of demo page conversion * update dos and donts props to be optional * Second batch of conversion done * updated according to lint rules * fixing some compilation issues * add change file
* master: Part 2 of demo page refactor (microsoft#5089) Update jest.js fixing official example page and datepicker/calendar components using… (microsoft#5108) Don't run prettier and tslint in parallel as it might cause conflicts (microsoft#5100) FocusTrapZone - restore last focused descendant element (microsoft#5103) Coachmark/TeachingBubble: Fix SCSS selectors for buttons and Close Icon (microsoft#4835) HoverCard: IE11 fix (microsoft#5105)
kkjeer
pushed a commit
that referenced
this pull request
Jun 11, 2018
* Mv Slider implementation to .base.tsx * Export Slider.base * Slider impl with getStyles and interface imports * Refactor hierarchy to Slider.styles and expose via interfaces * Reflect current set of style attrs and globals * + changefile * Update Slider snapshot test * Refactor Slider tests to test SliderBase * Add SliderBase type param throughout Slider tests * Test Slider for snapshot comparison only * Minor typing fix per PR feedback.
kkjeer
pushed a commit
that referenced
this pull request
Oct 8, 2018
* Fix microsoft#6360 microsoft#12 - Unique IDs for CtxMenu demo page examples. * Fix microsoft#6360 #2: Add label for hover delay TextField example * Fix microsoft#6360 #1: Add aria-label to search input on filter CtxMenu example * Add changefiles * Update ContextualMenu snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think i removed all the files that you didn't aim to modify and merged with latest master