Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @MainActor to every ViewState #31

Merged
merged 5 commits into from Oct 27, 2022
Merged

Add @MainActor to every ViewState #31

merged 5 commits into from Oct 27, 2022

Conversation

kkebo
Copy link
Owner

@kkebo kkebo commented Oct 12, 2022

*ViewStates should have a @MainActor attribute, but in Swift 5.6 it was a little bit difficult to do so, and this has been resolved in Swift 5.7. Therefore, this change was made.

This PR requires #27.

@kkebo kkebo added the enhancement New feature or request label Oct 12, 2022
@kkebo kkebo self-assigned this Oct 12, 2022
@kkebo kkebo marked this pull request as draft October 12, 2022 17:29
@kkebo kkebo changed the title Add @MainActor for every ViewState Add @MainActor to every ViewState Oct 13, 2022
@kkebo kkebo marked this pull request as ready for review October 27, 2022 10:55
@kkebo kkebo merged commit f8ebeec into main Oct 27, 2022
@kkebo kkebo deleted the mainactor branch October 27, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant