Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color-detection is not working well #4

Closed
eyalf-nvidia opened this issue Jan 6, 2021 · 2 comments
Closed

Color-detection is not working well #4

eyalf-nvidia opened this issue Jan 6, 2021 · 2 comments

Comments

@eyalf-nvidia
Copy link
Contributor

I am not sure why, but, the color detection is not working too well for me (can send some images if needed). The colors that are detected are pretty unstable/jumpy as well.

BTW, i already have a suggestion for a new coolor-detection scheme and would love to push it as a PR for you to review/pull if you want. At the moment your Repo is locked for pushing new branches/PRs :(.

@kkoomen
Copy link
Owner

kkoomen commented Jan 7, 2021

I am not sure why, but, the color detection is not working too well for me

Please read the README: One of the main things that killed me during developing this was color detection. It works for my room, but I bet it doesn't work for you, or you must have the same lighting and color scheme as I do.

BTW, i already have a suggestion for a new coolor-detection scheme and would love to push it as a PR for you to review/pull if you want.

Go ahead.

At the moment your Repo is locked for pushing new branches/PRs :(.

You have to fork my repo, create a new branch and do a PR from your fork to this repo.

@eyalf-nvidia
Copy link
Contributor Author

Got ya. Used to a private GitHub (Organization).. Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants