-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected regex match #192
Comments
alexdima
added a commit
to microsoft/vscode-oniguruma
that referenced
this issue
Apr 22, 2020
kkos
added a commit
that referenced
this issue
Apr 22, 2020
Thank you for your research. It may be quite serious, so an urgent release may be needed. |
kkos
added a commit
that referenced
this issue
Apr 26, 2020
bob-beck
pushed a commit
to openbsd/ports
that referenced
this issue
Apr 27, 2020
"This is a bug that if the look-behind contains a branch with a character length of 0 and an anchor is included in the branch, the whole look-behind is ignored."
kkos
added a commit
that referenced
this issue
Jul 11, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the
sample/bug_fix.c
file, insert the following:I would expect to see in the output:
But instead there is printed:
I have done
git bisect
and it led towards 32e688b:I am sorry for the very complex regular expression and for not spending more time to simplify it, but I believe it has something to do with the look behind starting with
(?<=[({\\[ ...
. It is almost as if it is not checked. I have hit this regular expression in VS Code's JavaScript TM grammar, while validating/updating VS Code's oniguruma version with a fresh WASM implementation here.Thank you for your great work, and special thanks for the new RegSet API, which might save a lot of time in parsing TM grammars.
The text was updated successfully, but these errors were encountered: