797 Set the map language to UI language in new branch #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting invalid. And use zoom:1 to show the global map.
switch to my forked repo
newer images
switch to my forked repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution of photoview#789. The language of the map in Place will be set to the same as the UI. If the UI language is NOT supported by Mapbox, then the English map will be provided.
This is a new pull request of setting the map language to UI language, and I commit it to a new branch other than master. The old one will be closed soon.
As per the comment in the old pull request photoview#790, I deleted the settings of zoom and center and deleted the setting of projection, which means the map language cannot be changed.
I have looked at the commit setting the projection, it said "chore: add mapbox globe view", so I guess the committer just wants to show the mapbox with the whole world map initially. But I think maybe he or she doesn't know what the projection really means, in fact, global projection just makes a spherical map. So, I add zoom: 1 to show the mapbox with the whole world map initially.