Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert charging eth for gas usage #692

Merged
merged 1 commit into from
Dec 28, 2023
Merged

revert charging eth for gas usage #692

merged 1 commit into from
Dec 28, 2023

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Dec 28, 2023 •
edited

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #

What is the new behavior?

  • as EF-Tests is not ready for this, revert this to have better metrics on passing/failing tests due to other reasons than gas.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat added this pull request to the merge queue Dec 28, 2023
Merged via the queue into main with commit 0cdd467 Dec 28, 2023
4 checks passed
@enitrat enitrat deleted the revert/gas-charge-eth branch December 28, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greged93 greged93 greged93 approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@enitrat @greged93