Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use web3 with Kakarot RPC in end-to-end tests when available #1164

Merged
merged 1 commit into from
May 30, 2024
Merged

Use web3 with Kakarot RPC in end-to-end tests when available #1164

merged 1 commit into from
May 30, 2024

Conversation

ClementWalter
Copy link
Member

@ClementWalter ClementWalter commented May 30, 2024 •
edited

This change is Reviewable

@ClementWalter ClementWalter force-pushed the cw/use-web3-in-end-to-end branch 3 times, most recently from 7f3dd24 to 1eebaa6 Compare May 30, 2024 12:38
greged93
greged93 requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for screenshot of the tests passing on local rpc docker

@ClementWalter
Copy link
Member Author

image tests running on the RPC (Counter precompiles not passing because there are not deployed yet on the RPC side)

@ClementWalter ClementWalter merged commit b72acf9 into kkrt-labs:main May 30, 2024
6 checks passed
@ClementWalter ClementWalter deleted the cw/use-web3-in-end-to-end branch May 30, 2024 14:49
enitrat pushed a commit that referenced this pull request Jun 6, 2024
@ClementWalter @enitrat
Use web3 with Kakarot RPC in end-to-end tests when available (#1164)
ea23489 
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1164)
<!-- Reviewable:end -->
enitrat pushed a commit that referenced this pull request Jun 6, 2024
@ClementWalter @enitrat
Use web3 with Kakarot RPC in end-to-end tests when available (#1164)
4b64238 
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1164)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greged93 greged93 greged93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ClementWalter @greged93