Skip to content

Commit

Permalink
fix: fix module errors.
Browse files Browse the repository at this point in the history
  • Loading branch information
jaywcjlove committed Jun 11, 2021
1 parent 0a1e780 commit a3c4f63
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 22 deletions.
15 changes: 8 additions & 7 deletions core/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import { Configuration } from 'webpack';
import { ParsedArgs } from 'minimist';

export * from './overrides/paths';
export * from './utils/loaderConf';
export * from './utils/getStyleLoaders';
export * from './utils/path';
export * from './scripts/build';
export * from './scripts/start';
export * from './scripts/testk';

import build from './scripts/build';
import start from './scripts/start';
import test from './scripts/testk';
export interface BuildArgs extends ParsedArgs {
overridesWebpack?: (conf: Configuration) => Configuration;
}

export { build, start, test };
export interface StartArgs extends BuildArgs {}
export interface TestArgs extends ParsedArgs {}
9 changes: 3 additions & 6 deletions core/src/scripts/build.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
process.env.NODE_ENV = 'production';

import { Configuration } from 'webpack';
import { ParsedArgs } from 'minimist';
import { KKTRC } from '../utils/loaderConf';
import { reactScripts, isWebpackFactory } from '../utils/path';
import { overridePaths } from '../overrides/paths';
import { miniCssExtractPlugin } from '../utils/miniCssExtractPlugin';
import { BuildArgs } from '..';

export interface Build extends ParsedArgs {
overridesWebpack?: (conf: Configuration) => Configuration;
}

export default async function build(argvs: Build) {
export default async function build(argvs: BuildArgs) {
try {
const paths = await overridePaths(argvs);
const webpackConfigPath = `${reactScripts}/config/webpack.config${!isWebpackFactory ? '.prod' : ''}`;
Expand Down
9 changes: 3 additions & 6 deletions core/src/scripts/start.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
process.env.NODE_ENV = process.env.NODE_ENV || 'development';

import webpack, { Configuration } from 'webpack';
import { ParsedArgs } from 'minimist';
import WebpackDevServer, { ProxyConfigArrayItem } from 'webpack-dev-server';
import { KKTRC, DevServerConfigFunction } from '../utils/loaderConf';
import { reactScripts, isWebpackFactory, proxySetup } from '../utils/path';
Expand All @@ -10,12 +10,9 @@ import { overridesClearConsole } from '../overrides/clearConsole';
import { overridesChoosePort } from '../overrides/choosePort';
import { miniCssExtractPlugin } from '../utils/miniCssExtractPlugin';
import { cacheData } from '../utils/cacheData';
import { StartArgs } from '..';

export interface Start extends ParsedArgs {
overridesWebpack?: (conf: Configuration) => Configuration;
}

export default async function start(argvs: Start) {
export default async function start(argvs: StartArgs) {
try {
const paths = await overridePaths(argvs);
const webpackConfigPath = `${reactScripts}/config/webpack.config${!isWebpackFactory ? '.dev' : ''}`;
Expand Down
5 changes: 2 additions & 3 deletions core/src/scripts/testk.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
process.env.NODE_ENV = process.env.NODE_ENV || 'test';

import { ParsedArgs } from 'minimist';
import { reactScripts } from '../utils/path';
import { TestArgs } from '..';

export interface Test extends ParsedArgs {}
export default async function test(argvs: Test) {
export default async function test(argvs: TestArgs) {
try {
// run original script
require(`${reactScripts}/scripts/test`);
Expand Down

0 comments on commit a3c4f63

Please sign in to comment.