-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RefferenceError: results is not defined on v2.0.2 #7
Comments
Alright, I'll have a look at this.I can add some hardening in the results call. I currently am not able to reproduce. |
Hi Klaas I have the same problem with all searches: ReferenceError: results is not defined
at /Users/peter/.nvm/versions/node/v12.4.0/lib/node_modules/alfred-mdn/index.js:9:23 |
@peterschussheim @evanre how do you install the plugin? I just did a removal + reinstall and still works for me:
|
I uninstalled the previous version and installed the latest exactly as you did. Did that 3 times today just to be sure. |
@klaascuvelier I only typed
Yes, it repeats on any query. |
Strange, but after I've tried to debug it (I just put console log in |
still not working on my machine |
I'll reopen this one, as there's still people with the same issue> |
I just published 2.0.3 which adds a check on For people still experiencing issues, can you perhaps debug the |
@klaascuvelier |
Weird, perhaps callback gets called multiple times? First time the results aren't available, 2nd time they are. So before with the incomplete/empty result code broke and 2nd call did not happen. |
@klaascuvelier 2.0.3 works. Thank you, I appreciate the time you put into fixing this promptly. |
Published another version with the changes of the MDN endpoint. If @evanre also has no problems anymore, then we can close this ticket :) |
@klaascuvelier It works great. Thank you for your extension! |
Hi, I've just updated alfred-mdn to check if it's working after #6 fixin and got this error:
The text was updated successfully, but these errors were encountered: