Skip to content
This repository has been archived by the owner on Oct 9, 2019. It is now read-only.

Does not support ng-model #1

Closed
hyrumwhite opened this issue Aug 8, 2014 · 3 comments
Closed

Does not support ng-model #1

hyrumwhite opened this issue Aug 8, 2014 · 3 comments

Comments

@hyrumwhite
Copy link

I'm trying out your code, currently the animation functionality disappears when you add an ng-model to the input tag.

@klaascuvelier
Copy link
Owner

Thanks for noticing, I'll check this asap.

@jtorbicki
Copy link

Quickfix, change this:

templateAttributes.push(attr + '="' + $attrs[attr] + '"');

to this:

if (attr !== 'floatingLabel') {
  templateAttributes.push($attrs.$attr[attr] + '="' + $attrs[attr] + '"');
}

klaascuvelier added a commit that referenced this issue Jan 13, 2015
@klaascuvelier
Copy link
Owner

Thanks for the suggestion @jtorbicki! This worked perfectly.
I updated the code and the example (to have an ng-model to prove this fix).

If I find some time I will maybe add some automated tests and publish this to bower and npm

Thanks @jtorbicki and @hyrumwhite

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants