Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a calculation bug for total energy #19

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Conversation

klaasnicolaas
Copy link
Owner

I made a miscalculation for total energy for who is using the JS source of the inverter.

@klaasnicolaas klaasnicolaas added the bugfix Fixing a bug. label Sep 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #19 (ed4805d) into master (2d89da0) will decrease coverage by 0.63%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   87.09%   86.45%   -0.64%     
==========================================
  Files           4        4              
  Lines          93       96       +3     
  Branches       10       12       +2     
==========================================
+ Hits           81       83       +2     
  Misses          9        9              
- Partials        3        4       +1     
Impacted Files Coverage Δ
omnikinverter/models.py 97.43% <75.00%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d89da0...ed4805d. Read the comment docs.

@klaasnicolaas klaasnicolaas merged commit fbcbb87 into master Sep 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
@klaasnicolaas klaasnicolaas deleted the fix-total_energy branch September 17, 2021 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Fixing a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants