Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch invalid temperature for offline inverters using TCP #336

Merged
merged 3 commits into from
Feb 13, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion omnikinverter/tcp.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,10 +272,17 @@ def int_to_bool(num: int) -> bool:
"firmware_slave": None,
}

result = {}
result: dict[str, Any] = {}

for (name, extractor) in field_extractors.items():
value = getattr(tcp_data, name)

# Set temperature to None if it matches 65326, this is returned
# when the inverter is "offline".
if name == "temperature" and value == 65326:
result["temperature"] = None
robbinjanssen marked this conversation as resolved.
Show resolved Hide resolved
continue

if name == "ac_output":
# Flatten the list of frequency+power AC objects

Expand Down
Binary file added tests/fixtures/tcp_reply_offline.data
Binary file not shown.
46 changes: 46 additions & 0 deletions tests/test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,52 @@ def recv_side_effect(_max_bytes: int) -> bytes:
assert inverter.firmware == "NL1-V1.0-0077-4"
assert inverter.firmware_slave == "V2.0-0024"

async def test_inverter_tcp_offline(self) -> None:
"""Test request from an Inverter (offline) - TCP source."""
serial_number = 1608449224
socket_mock = asynctest.SocketMock()
socket_mock.type = socket.SOCK_STREAM

def send_side_effect(data: bytes) -> int:
assert data == tcp.create_information_request(serial_number)
asynctest.set_read_ready(socket_mock, self.loop)
return len(data)

def recv_side_effect(_max_bytes: int) -> bytes:
return load_fixture_bytes("tcp_reply_offline.data")

socket_mock.send.side_effect = send_side_effect
socket_mock.recv.side_effect = recv_side_effect

client = OmnikInverter(
host="example.com",
source_type="tcp",
serial_number=serial_number,
_socket_mock=socket_mock,
)

inverter: Inverter = await client.inverter()

assert inverter
assert inverter.solar_rated_power is None
assert inverter.solar_current_power == 0

assert inverter.model is None
assert inverter.serial_number == "NLBN4020157P9024"
assert inverter.temperature is None
assert inverter.dc_input_voltage == [0.0, 0.0, 0.0]
assert inverter.dc_input_current == [0.0, 0.0, 0.0]
assert inverter.ac_output_voltage == [0.0, 0.0, 0.0]
assert inverter.ac_output_current == [0.0, 0.0, 0.0]
assert inverter.ac_output_frequency == [0.0, 0.0, 0.0]
assert inverter.ac_output_power == [0.0, 0.0, 0.0]
assert inverter.solar_energy_today == 4.7
assert inverter.solar_energy_total == 15818.0
assert inverter.solar_hours_total == 0
assert inverter.inverter_active is False
assert inverter.firmware == ""
assert inverter.firmware_slave == ""

async def test_connection_broken(self) -> None:
"""Test on connection broken after success - TCP source."""
serial_number = 1
Expand Down