New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solis wifistick alternative approach #95
Solis wifistick alternative approach #95
Conversation
Only convert to int when value received
Fix UTF-8 bom Fix lint errors
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 181 188 +7
Branches 35 38 +3
=========================================
+ Hits 181 188 +7
Continue to review full report at Codecov.
|
It was a bit tricky because the codepath is only triggered when there is a session active, so during a request, but I have it covered now. |
I think this makes it a bit clearer what the test stands for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test with another inverter and made a few more minor changes, ready for merging!
This is an alternative approach to the changes in PR #55.
Instead of not allowing a session to be provided it will now use the provided session or create a session for one time use.
Note that I don't really like the big
try/finally
block, but it seemed better than putting callse toclose()
all over the place which is errorprone.