Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to the default plugin order not respected after 1988ab5 #205

Closed
cnuahs opened this issue Sep 1, 2022 · 0 comments
Closed

Changes to the default plugin order not respected after 1988ab5 #205

cnuahs opened this issue Sep 1, 2022 · 0 comments
Labels
bug

Comments

@cnuahs
Copy link
Contributor

cnuahs commented Sep 1, 2022

Commit 1988ab5 re: #190 introduced a bug wherein any changes to the default plugin ordering are immediately reverted in cic.run() when handling adaptive plugins.

On the current master branch this is due to a call to c.order() (without arguments) in cic.handleAdaptives(). Calling c.order() without arguments restores the default plugin order, reverting any changes made by the user.
@cnuahs cnuahs changed the title Changes to the default plugin order not respected after #1988ab5 Changes to the default plugin order not respected after 1988ab5 Sep 1, 2022
@cnuahs cnuahs added the bug label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cnuahs @bartkrekelberg