jittered parameters not updating #190
Labels
Comments
|
One option is for the adaptive base class to define a beforeTrial() method that calls updateValue(). |
cnuahs
added a commit
to cnuahs/neurostim
that referenced
this issue
Feb 4, 2022
bartkrekelberg
added a commit
that referenced
this issue
Apr 11, 2022
Proposed fix for issue #190 (re: jittered parameters not updating)
|
Fixed i #192 |
cnuahs
added a commit
to cnuahs/neurostim
that referenced
this issue
Sep 1, 2022
This change fixes a bug introduced by commit 1988ab5 (re: klabhub#190) that causes any changes to the default plugin order, imposed in cic.run(), to be immediately reverted when handling adaptive plugins/parameters (see cic.handleAdaptives()). This change removes the call to c.order(), which reverts the plugin order, in favour of using c.pluginOrder directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It appears that parameters that are directly assigned a jitter object are not updated after #188.
When a jitter object (or any adaptive object for that matter) is part of a block/design object, then the block object calls it's updateValue() method in it's beforeTrial(). However, when the jitter object is NOT part of a block/design, i.e., it is assigned directly to a parameter, then it's updateValue() method is never called. As a result, jittered parameters retain the same (random) value on all trials.
The text was updated successfully, but these errors were encountered: