DISPLAY++ color mode #187
Merged
DISPLAY++ color mode #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new screen.type "DISPLAY++COLOR" for chromatic stimulus presentation with the Display++ screen.
|
This is one for @bartkrekelberg and @cnuahs, who are more on top of the display types and of any possible consequences for overlays and other things. |
bartkrekelberg
approved these changes
Oct 8, 2021
|
As far as I tested with a Display++ screen @Monash, it works fine. I have not encountered any errors due to the screen mode. And the number of frame drops is as small as that in the monochrome mode (~10 dropped frames out of 600000 frames). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new screen.type "DISPLAY++COLOR" for chromatic stimulus presentation with the Display++ screen.